Skip to content
GitLab
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • Siril Siril
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 120
    • Issues 120
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 6
    • Merge requests 6
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • FA
  • SirilSiril
  • Merge requests
  • !414

make all seq commands consistent

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged cec m requested to merge cmd_select into master Feb 06, 2023
  • Overview 4
  • Commits 12
  • Pipelines 6
  • Changes 4

Review all the commands applicable to sequences:

command argument comment Done
getref seqname change to sequencename [x]
light_curve sequencename [x]
merge sequence1 no change required [x]
preprocess sequencename [x]
register sequence change to sequencename [x]
select add sequencename argument + make scriptable [x]
seqapplyreg sequencename [x]
seqclean sequencename [x]
seqcosme sequencename [x]
seqcosme_cfa sequencename [x]
seqcrop sequencename [x]
seqextract_Green sequencename [x]
seqextract_Ha sequencename [x]
seqextract_HaOIII sequencename [x]
seqheader sequencename [x]
seqfind_cosme sequencename [x]
seqfind_cosme_cfa sequencename [x]
seqfindstar sequencename [x]
seqfixbanding sequencename [x]
seqmerge_cfa sequencename [x]
seqmtf sequencename [x]
seqpsf [sequencename ~~add required sequencename argument ~~ [ ]
seqplatesolve sequencename [x]
seqrl sequence change to sequencename [x]
seqsb sequence change to sequencename [x]
seqsplit_cfa sequencename [x]
seqstarnet sequence change to sequencename [x]
seqstat sequencename [x]
seqsubsky sequencename [x]
seqtilt [sequencename] add required sequencename argument [x]
seqwiener sequence [x]
setmagseq magnitude add sequencename argument + rename to seqsetmag [x]
unselect add sequencename argument + make scriptable [x]
unsetmagseq add sequencename argument + rename to sequnsetmag [x]

Make sure they all call load_sequence so that . is a valid argument (replaces loaded sequence with its name).
Make sure they all have the same consistent sequencename argument.
Make sure sequencename argument is never optional

Note: seqpsf has been left out of this round of review. sequencename is still optional. Will reconsider in the future.

Edited Feb 12, 2023 by cec m
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: cmd_select