Fixing commands for scripted GUI execution
Following #770 (closed), a review of the scriptable commands has been made. Here's the list of those that call GTK+ code.
Also note that most commands call redraw_preview() and redraw(REMAP_ALL), which do nothing when com.script is true, and that many commands free their arguments in the idle function that is not called when com.script
is true.
We could either fix redraw_previews
and adjust_cutoff_from_updated_gfit
which are the most used functions, or make a generic idle function to call.
The hardest work was to fix load
and close
, which has been done here: branch synchronized_script_gui
, commit 03ecff0d.
command | status |
---|---|
asinh | ok |
bg | ok |
bgnoise | ok |
cd | ok |
cdg | ok |
clahe | ok |
close | refactored in the new branch |
convert | ok |
convertraw | ok |
cosme | ok |
cosme_cfa | ok |
crop | delete_selected_area (new_selection_zone) not ok |
entropy | ok |
exit | gtk_main_quit, seems to be ok |
extract | ok |
extract_Ha | ok |
extract_Green | ok |
extract_HaOIII | ok |
fdiv | ok |
fftd | ok |
ffti | ok |
fill | ok |
fill2 | ok |
find_cosme | ok |
find_cosme_cfa | ok |
find_hot | ok |
fix_xtrans | ok |
fixbanding | ok |
fmedian | ok |
fmul | ok |
gauss | ok |
grey_flat | ok |
histo | ok |
iadd | ok |
idiv | ok |
imul | ok |
isub | ok |
linear_match | ok |
link | ok |
load | refactored in the new branch |
log | ok |
merge | ok |
mirrorx | ok |
mirrory | ok |
mtf | ok |
neg | ok |
nozero | ok |
offset | ok |
preprocess | ok |
register | ok |
requires | ok |
resample | calls invalidate_WCS_keywords that calls update_MenuItem (not ok) |
rgradient | ok |
rl | ok |
rmgreen | ok |
rotate | ok |
rotatePi | ok |
satu | ok |
save | ok |
savebmp | ok |
savejpg | ok |
savepng | ok |
savepnm | ok |
savetif | ok |
savetif32 | ok |
savetif8 | ok |
seqextract_Ha | ok |
seqextract_Green | ok |
seqextract_HaOIII | ok |
seqcosme | ok |
seqcosme_cfa | ok |
seqcrop | ok |
seqfind_cosme | ok |
seqfind_cosme_cfa | ok |
seqmtf | ok |
seqsplit_cfa | ok |
seqstat | ok |
seqsubsky | ok |
set16bits | set_GUI_misc not ok |
set32bits | set_GUI_misc not ok |
setcompress | set_GUI_compression not ok |
setcpu | update_spinCPU not ok |
setext | ok |
setfindstar | ok |
setmem | set_GUI_misc not ok |
setref | ok |
split | fixed a crash, ok |
split_cfa | ok, not threaded |
stack | ok |
stackall | ok |
stat | ok |
subsky | not ok, calls is_dither_checked() from GUI in remove_gradient_from_image()
|
threshlo | ok |
threshhi | ok |
thresh | ok |
unsharp | ok |
wavelet | ok |
wrecons | ok |
Edited by Vincent Hourdin