Doesn't compile with libgit2 feature disabled

Siril version: 1.4.0

Operating System: Linux (Gentoo)

Package: Compiled from source to package for Gentoo

Description of the bug

The source code doesn't compile with libgit2 feature disabled and curl feature enabled.

Reproduction

Reproduction steps:

  1. meson setup ... -Dlibgit2=false -Dlibcurl=true ...
  2. Compile

Expected result:

Source compiles sucessfully

Actual result:

FAILED: [code=1] src/libsiril.a.p/io_siril_pythonmodule.c.o 
x86_64-pc-linux-gnu-gcc -Isrc/libsiril.a.p -Isrc -I../siril-1.4.0/src -Isubprojects/htmesh -I../siril-1.4.0/subprojects/htmesh -Isubprojects/healpix_cxx -I../siril-1.4.0/subprojects/healpix_cxx -Isubprojects/kplot -I../siril-1.4.0/subprojects/kplot -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/lib64/libffi/include -I/usr/include/libmount -I/usr/include/uuid -I/usr/include/json-c -I/usr/include/blkid -I/usr/include/gio-unix-2.0 -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/webp -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/atk-1.0 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/elogind -I/usr/include/fribidi -I/usr/include/libpng16 -I/usr/include/pixman-1 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/opencv4 -I/usr/include/wcslib -I/usr/include/gtksourceview-4 -I/usr/include/libxml2 -fdiagnostics-color=always -Wall -Winvalid-pch -std=gnu11 -march=native -O2 -pipe -fPIC -pthread -DHAVE_CONFIG_H -fcommon -fno-math-errno -D_FILE_OFFSET_BITS=64 -MD -MQ src/libsiril.a.p/io_siril_pythonmodule.c.o -MF src/libsiril.a.p/io_siril_pythonmodule.c.o.d -o src/libsiril.a.p/io_siril_pythonmodule.c.o -c ../siril-1.4.0/src/io/siril_pythonmodule.c
../siril-1.4.0/src/io/siril_pythonmodule.c: In function ‘handle_pixeldata_request’:
../siril-1.4.0/src/io/siril_pythonmodule.c:404: warning: ignoring ‘#pragma omp parallel’ [-Wunknown-pragmas]
  404 | #pragma omp parallel for collapse(2) num_threads(com.max_thread)
../siril-1.4.0/src/io/siril_pythonmodule.c:418: warning: ignoring ‘#pragma omp parallel’ [-Wunknown-pragmas]
  418 | #pragma omp parallel for collapse(2) num_threads(com.max_thread)
../siril-1.4.0/src/io/siril_pythonmodule.c: In function ‘prepare_venv_environment’:
../siril-1.4.0/src/io/siril_pythonmodule.c:2156:68: error: ‘update_repo_scripts_list_and_menu_in_thread’ undeclared (first use in this function)
 2156 |                 g_thread_unref(g_thread_new("update_scripts_list", update_repo_scripts_list_and_menu_in_thread, NULL));
      |                                                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../siril-1.4.0/src/io/siril_pythonmodule.c:2156:68: note: each undeclared identifier is reported only once for each function it appears in

Additional information

In src/io/siril_git.h the declaration of update_repo_scripts_list_and_menu_in_thread() is conditional on HAVE_LIBGIT2, but the function is called unconditionally in src/io/siril_pythonmodule.c.

Edited by Mario Haustein