GitLab

Format PHP code

Some equality checks were changed from == to === and != to !==

Use ! empty() instead, or cast variable to array.

Format SubmitButton() calls

To finish, next is Grades/TeacherCompletion.php

Prevents showing an obsolete & confusing delete confirmation screen
on page reload.
Formatted code.
Use PreparePHP_Self() in forms to maintain program state
in Administration.php & Eligibility/Student.php.
Fixed Cancel Delete Event in Calendar.php.
Remove "# Associated" column from Student list in AddStudents.php.
Added DBEscapeIdentifier() where missing.
Aggregated some if conditions to simplify update / remove logic.

Reduce HTML markup, better control over lists & headers
Move .cellspacing-0 inside .widefat
Move .width-100p & .cellspacing-0 inside .header
Move .width-100p inside .header & .list-header
Remove hardcoded <br /> after / before lists & errors & add CSS margins

Remove isset() checks!

Move (Staff)Widgets(), append(Staff)SQL() & CustomFields() functions calls inside GetStaffList() & GetStuList()

Real Fix Advanced Search :)

Replace "for($" with "for ( $"
Replace "for( " with "for ( "

Replace "if ($" with "if ( $"
Replace "if (!" with "if ( !"

Replace "foreach($" with "foreach ( (array)$"
Replace "foreach( " with "foreach ( "
Replace "foreach(array" with "foreach( array"
Replace "foreach(explode" with "foreach ( explode"

Replace "if(" with "if ("

//modif Francois: => //FJ

Remove inline CSS
Remove unused search_fnc
Remove unused $_ROSARIO['modules_search']
Fix Advanced Search

Remove inline style
Only PNG format for button() function
Create .button .bigger .smaller .cal CSS classes
Create new ErrorMessage: warning
Use button() function, always

- "RosarioSIS" program name in DB
- Display DB name in strings previously containing "RosarioSIS"
- Replace "RosarioSIS" with DB name in Help

- replace x.png with x_button.png
- replace check.png with check_button.png
- end IMG html tags

-Remove BackPrompt()
-reindent code
-take in account Search params for GetStuList

- Add error when no student selected

stripos => mb_stripos
strlen => mb_strlen
strpos => mb_strpos
strrchr =>
mb_strrchr
strrpos => mb_strrpos
strstr => mb_strstr
strtolower =>
mb_strtolower
strtoupper => mb_strtoupper
substr_count =>
mb_substr_count
substr => mb_substr

First commit on GitHub for RosarioSIS