From 89ae9de732024e3a2e99262aa98b400a1aa6975a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fran=C3=A7ois=20Jacquet?= Date: Tue, 14 Jul 2020 12:52:43 +0200 Subject: [PATCH] Fix #291 XSS Use URLEscape() for forms action --- CHANGES.md | 1 + modules/Accounting/DailyTotals.php | 2 +- modules/Accounting/DailyTransactions.php | 2 +- modules/Accounting/Expenses.php | 2 +- modules/Accounting/Incomes.php | 2 +- modules/Accounting/Salaries.php | 2 +- modules/Accounting/StaffPayments.php | 2 +- modules/Attendance/AddAbsences.php | 2 +- modules/Attendance/Administration_fast.old.php | 4 ++-- modules/Attendance/AttendanceCodes.php | 2 +- modules/Attendance/DuplicateAttendance.php | 2 +- modules/Attendance/Percent.php | 2 +- modules/Attendance/TakeAttendance.php | 10 +++++----- modules/Attendance/TeacherCompletion.php | 2 +- modules/Custom/AttendanceSummary.php | 4 ++-- modules/Custom/CreateParents.php | 4 ++-- modules/Custom/NotifyParents.php | 2 +- modules/Custom/Registration.php | 4 ++-- modules/Custom/RemoveAccess.php | 4 ++-- modules/Discipline/DisciplineForm.php | 2 +- modules/Discipline/MakeReferral.php | 4 ++-- modules/Discipline/Referrals.php | 2 +- modules/Eligibility/Activities.php | 2 +- modules/Eligibility/AddActivity.php | 2 +- modules/Eligibility/EnterEligibility.php | 2 +- modules/Eligibility/EntryTimes.php | 2 +- modules/Eligibility/Student.php | 4 ++-- modules/Eligibility/TeacherCompletion.php | 2 +- modules/Food_Service/AssignSchool.php | 2 +- modules/Food_Service/DailyMenus.php | 4 ++-- modules/Food_Service/MenuItems.php | 2 +- modules/Food_Service/Menus.php | 2 +- modules/Food_Service/Students/Accounts.php | 2 +- modules/Food_Service/Students/Reminders.php | 2 +- modules/Food_Service/Students/ServeMenus.php | 4 ++-- modules/Food_Service/Students/Transactions.php | 2 +- modules/Food_Service/TakeMenuCounts.php | 8 ++++---- modules/Food_Service/TeacherCompletion.php | 4 ++-- modules/Food_Service/Users/Accounts.php | 4 ++-- modules/Food_Service/Users/Reminders.php | 2 +- modules/Food_Service/Users/ServeMenus.php | 4 ++-- modules/Food_Service/Users/Transactions.php | 2 +- modules/Grades/AnomalousGrades.php | 2 +- modules/Grades/Assignments-new.php | 2 +- modules/Grades/Assignments.php | 12 ++++++------ modules/Grades/Configuration.php | 2 +- modules/Grades/EditHistoryMarkingPeriods.php | 2 +- modules/Grades/EditReportCardGrades.php | 8 ++++---- modules/Grades/FinalGrades.php | 4 ++-- modules/Grades/GradeBreakdown.php | 2 +- modules/Grades/Grades.php | 2 +- modules/Grades/HonorRoll.php | 4 ++-- modules/Grades/InputFinalGrades.php | 4 ++-- modules/Grades/MassCreateAssignments.php | 4 ++-- modules/Grades/ProgressReports.php | 4 ++-- modules/Grades/ReportCardCommentCodes.php | 4 ++-- modules/Grades/ReportCardComments.php | 4 ++-- modules/Grades/ReportCardGrades.php | 2 +- modules/Grades/TeacherCompletion.php | 2 +- modules/Grades/Transcripts.php | 2 +- modules/Resources/Resources.php | 2 +- modules/Scheduling/Courses.php | 14 +++++++------- modules/Scheduling/IncompleteSchedules.php | 2 +- modules/Scheduling/MassDrops.php | 2 +- modules/Scheduling/MassRequests.php | 2 +- modules/Scheduling/MassSchedule.php | 2 +- modules/Scheduling/Menu.php | 8 ++++---- modules/Scheduling/PrintClassLists.php | 4 ++-- modules/Scheduling/PrintClassPictures.php | 2 +- modules/Scheduling/PrintSchedules.php | 4 ++-- modules/Scheduling/Requests.php | 2 +- modules/Scheduling/Schedule.php | 2 +- modules/Scheduling/ScheduleReport.php | 2 +- modules/Scheduling/UnfilledRequests.php | 2 +- .../Scheduling/includes/ClassSearchWidget.fnc.php | 4 ++-- modules/Scheduling/new_Requests.php | 2 +- modules/School_Setup/AccessLog.php | 4 ++-- modules/School_Setup/Calendar.php | 6 +++--- modules/School_Setup/Configuration.php | 2 +- modules/School_Setup/CopySchool.php | 2 +- modules/School_Setup/DatabaseBackup.php | 2 +- modules/School_Setup/GradeLevels.php | 2 +- modules/School_Setup/MarkingPeriods.php | 2 +- modules/School_Setup/Periods.php | 2 +- modules/School_Setup/PortalNotes.php | 2 +- modules/School_Setup/PortalPolls.php | 2 +- modules/School_Setup/Rollover.php | 2 +- modules/School_Setup/Schools.php | 2 +- modules/School_Setup/includes/Modules.inc.php | 4 ++-- modules/School_Setup/includes/Plugins.inc.php | 4 ++-- modules/Student_Billing/DailyTotals.php | 2 +- modules/Student_Billing/DailyTransactions.php | 2 +- modules/Student_Billing/MassAssignFees.php | 2 +- modules/Student_Billing/MassAssignPayments.php | 2 +- modules/Student_Billing/StudentFees.php | 2 +- modules/Student_Billing/StudentPayments.php | 2 +- modules/Students/AddUsers.php | 2 +- modules/Students/AssignOtherInfo.php | 2 +- modules/Students/EnrollmentCodes.php | 2 +- modules/Students/Letters.php | 4 ++-- modules/Students/PrintStudentInfo.php | 4 ++-- modules/Students/Search.inc.php | 8 ++++---- modules/Students/StudentLabels.php | 6 ++++-- modules/Users/AddStudents.php | 2 +- modules/Users/Exceptions.php | 2 +- modules/Users/Preferences.php | 2 +- modules/Users/Profiles.php | 2 +- modules/Users/Search.inc.php | 4 ++-- modules/Users/TeacherPrograms.php | 2 +- plugins/Moodle/config.inc.php | 12 ++++++------ 110 files changed, 175 insertions(+), 172 deletions(-) diff --git a/CHANGES.md b/CHANGES.md index cb0f37b7..0e06a775 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -8,6 +8,7 @@ Changes in 6.8 - Fix Sunday is number 7 in EntryTimes.php - Fix SQL error multiple rows returned by subquery in CreateParents.php - Fix #291 XSS Use URLEscape() for links href, program wide +- Fix #291 XSS Use URLEscape() for forms action, program wide - Fix hide remove button for "No Address" in Address.inc.php - Prompt() make Cancel primary button in Prompts.php - Fix SQL error foreign keys: Roll again Courses when rolling Marking Periods in Rollover.php diff --git a/modules/Accounting/DailyTotals.php b/modules/Accounting/DailyTotals.php index 49ab1f77..a4abf705 100644 --- a/modules/Accounting/DailyTotals.php +++ b/modules/Accounting/DailyTotals.php @@ -14,7 +14,7 @@ $start_date = RequestedDate( 'start', date( 'Y-m' ) . '-01' ); // Set end date. $end_date = RequestedDate( 'end', DBDate() ); -echo '
'; +echo ''; $header_checkboxes = '