Skip to content

Fixed scroller height for fair-share-points and AMB foodsaver list

Johannes requested to merge fixed-scroller-height-parameter-jo into master

What does this MR do?

Fixed scroller height parameter and functionality for fair-share-points and AMB foodsaver list.

The default height which is programmatically set via jQuery scroller of is 250px. If you set it to auto, it is using the maxHeight of the <div> which is contained in.

Fair-share-point followers (screenshot shows 700px):
Not yet scrollable since it hasn't reached maxHeight.
fair-share-point

Foodsaver list for AMBs (screenshot shows 600px):
It's allready scrollable but you can't see it.
foodsaver-list

How confident are you it won't break things if deployed?

Should work.

Links to related issues

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
Edited by Chris Oelmueller

Merge request reports