Return conversation members after updating the denormalized members field
What does this MR do?
While testing the Android app with the dev environment, I often had the problem that the member fields of the conversation response had the value
false instead of the list of members on the first request.
Conversation members are currently cached in a members field in the conversation table.
Initially, this field is empty. In https://gitlab.com/foodsharing-dev/foodsharing/blame/master/src/Modules/Message/MessageModel.php#L245 this is checked and the field is updated. This was introduced in 1978fd1c.
Probably, due to some refactoring, the members field of the current response is currently not updated and thus is returned as
false in the first response.
How confident are you it won't break things if deployed?
Pretty sure, since it only replaces the value
false with the correct members array.
I tested it in the Android app and on the website.
Links to related issues
- added a test, or explain why one is not needed/possible...
- no unrelated changes
- asked someone for a code review
- joined #foodsharing-beta channel at https://slackin.yunity.org
- added an entry to CHANGELOG.md (description, merge request link, username(s))