Skip to content

Fixed with !874? : "off by 1h bug" in pickup time slot restriction

Johannes requested to merge fixed-pickup-time-bug-off-by-1h into master

What does this MR do?

Fixed "off by 1h bug". Used Carbon::parse instead of createFromFormat. Cherrypicked from jf-pickup-slot-changes for review and early merge

@NerdyProjects I thought this might be the easiest way for you to take a look on. I managed to get the correct time with my change but I'm not sure if it's the correct way. Can you please take a look? I'm also not sure how this is effected by the upcoming daylight saving time.

How confident are you it won't break things if deployed?

Tested it with the pickup time restrictions on master. Isn't off by 1h anymore --> works.

Related links

!771 (closed)

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
Edited by Johannes

Merge request reports