Skip to content

Fix some things regarding the recent email template changes

Matthias Larisch requested to merge fix-html-escaping-in-emails into master

What does this MR do?

  • Properly handle forum template variables: Accept content as HTML, do not convert other stuff to HTML as twig mail templates properly escapes stuff
  • refactors excerpt function to be more easily understandable and reuse code
    • fix sanitizer tt method which creates a truncated sentence keeping words complete (unicode aware now)
  • properly NOT handle urls as html
  • Removes redis caching for infomail or similarly named redis keys - added just that field to an anyway happening database query
  • renamed some email templates
  • extended some email templates
  • wrote some more tests regarding email content

How confident are you it won't break things if deployed?

I want to add some more tests

Links to related issues

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
Edited by Chris Oelmueller

Merge request reports