Skip to content
Snippets Groups Projects

Fix Fairteiler posts for non-followers

Merged Fix Fairteiler posts for non-followers
467_fix_fairteiler_posts into master
Merged Jano requested to merge 467_fix_fairteiler_posts into master

Closes #467 (closed)

What does this MR do?

It removes the mayFairteiler() function, that always returned false if one was not a follower of the Fairteiler, and all the places it has been called.

mayFairteiler() has been introduced in b1132e50 and has been called before the bell notifications for Fairteiler followers have been triggered. That caused bells not to be sent for fairteiler posts authored by non-followers. I think this is incorrect behaviour; that's why I removed the function completely. If you think, non-followers should be able to post, but their posts should not trigger bell notification being sent to the followers, I'll revert that.

Later, I called the function in WallPostPermissions too, thinking that it would contain correct permission logic. That caused non-followers not being able to submit Fairteiler posts any more.

Links to related issues

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
Edited by Chris Oelmueller

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply