Skip to content

Resolve "Make name on top of chat an active link to the members profile."

Thomas Pfeiffer requested to merge 100-link-name-from-top-of-chat-to-profile into master

Closes #100 (closed)

What does this MR do?

Links the user name(s) in the chat title to their profiles. I also had to remove the overall anchor tag from the title to avoid nested anchor tags, had to add the pointing cursor to the chatboxtitle class so that users still realize they can click anywhere on the title to open/close the box, and had to remove "return false" from the onclick event of the title because it didn't allow the link to be followed.

How confident are you it won't break things if deployed?

I've run all tests and I've played around with the chat to see if it breaks anything, and it didn't. The only thing I'm unsure of is the removed "return false" from the onklick method of the chatboxtitle. I don't know what it would needed for, but I'm not 100% sure it doesn't break anything in some corner cases.

Links to related issues

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
Edited by Thomas Pfeiffer

Merge request reports