Skip to content

Remove broken login method

Tilmann Becker requested to merge remove-broken-login-popup into master

Closes https://sentry.io/foodsaving-worldwide/foodsharingde-production/issues/613674312

What does this MR do?

Removes broken login method LoginXhr->login() and dependent code.

It was broken in !403 (merged) as LoginView->loginForm was removed.

It's unclear to me where the login() method was ever called from. The only occurrence is in a return value from the ProfileXhr constructor, but constructor return values aren't used anywhere. So it remains a mystery where https://sentry.io/foodsaving-worldwide/foodsharingde-production/issues/613674312 comes from.

How confident are you it won't break things if deployed?

It was already broken, can only get better.

Links to related issues

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
Edited by Chris Oelmueller

Merge request reports