Remove broken login method
Closes https://sentry.io/foodsaving-worldwide/foodsharingde-production/issues/613674312
What does this MR do?
Removes broken login method LoginXhr->login() and dependent code.
It was broken in !403 (merged) as LoginView->loginForm was removed.
It's unclear to me where the login() method was ever called from. The only occurrence is in a return value from the ProfileXhr constructor, but constructor return values aren't used anywhere.
So it remains a mystery where https://sentry.io/foodsaving-worldwide/foodsharingde-production/issues/613674312 comes from.
How confident are you it won't break things if deployed?
It was already broken, can only get better.
Links to related issues
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
joined #foodsharing-beta channel at https://slackin.yunity.org -
added an entry to CHANGELOG.md (description, merge request link, username(s))
Merge request reports
Activity
added 5 commits
-
2cc6e239...facb2b67 - 4 commits from branch
master - 9e409c92 - Remove broken login popup
-
2cc6e239...facb2b67 - 4 commits from branch
https://sentry.io/foodsaving-worldwide/foodsharingde-production/issues/613674312 does throw lots of errors, I wonder how they get triggered...
It might come from the android app? Some ppl still used it because chat was working well enough. Just guessing
Sent from GitLab Control
@k.miklobusec there is a possibility that the app is calling this method from here: https://gitlab.com/foodsharing-dev/foodsharing-android/blob/master/www/js/user.js#L112
But I could not trigger this error from within my app. Strange.
assigned to @tiltec
added 90 commits
-
9e409c92...8c00060b - 89 commits from branch
master - dc98f88a - Remove broken login popup
-
9e409c92...8c00060b - 89 commits from branch
changed milestone to %August 2018
