Skip to content

Remove duplicated tplMail method

Matthias Larisch requested to merge remove-console-email-duplication into master

What does this MR do?

ConsoleControl had a slightly modified copy from tplMail from Func. Use the Func version instead.

I carefully checked behaviour by reading the code, but there is not a single CLI mail send test. I recognized this behaviour by getting wrongly formatted emails from the nightly pickup notification run - as the ConsoleControl version was not changed to use proper HTML2Text (which it needs since a few days...)

How confident are you it won't break things if deployed?

quite.

Links to related issues

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))

Merge request reports