Skip to content
Snippets Groups Projects

Resolve "follow-up from voting tool"

Merged Resolve "follow-up from voting tool"
975-anton-follow-up-from-voting-tool into master
Merged Anton Ballmaier requested to merge 975-anton-follow-up-from-voting-tool into master

What does this MR do?

Addresses the following open tasks from #975:

  • Always save polls in the correct time (independent of time zone)
  • Increase max option text length from 200 to 1000 chars and make sure, no longer option texts can be entered
  • Apply Markdown to poll option texts
  • Display number of eligible voters when selecting poll scope, add help explaining poll scopes
  • Display positive values with + sign in score and thumb voting
  • Show average, sum and std. deviation
  • Show if a user is allowed to vote in the vote list

Required migration (executed :white_check_mark:)

ALTER TABLE `fs_poll_has_options` CHANGE `option_text` `option_text` VARCHAR(1000) NULL;

How confident are you it won't break things if deployed?

There might be some minor frontend related inconsistencies, but I don't think this will break anything.

Links to related issues

#975

How to test

Create and tests polls. Changing the polls start and end date in the db can make the testing easier.

Screenshots (if applicable)

grafik

grafik

grafik

grafik

grafik

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • set the "API change" label if changes in the API are not backward compatible
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text in the release notes to /release-notes/YYYY-MM.md
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/region?bid=2296&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.
Edited by Anton Ballmaier

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply