save working group Function on the first run
Merged
requested to merge Region-Admin-Tool--Working-Group-Function-is-not-saved-on-the-first-run into master
Closes #2044 (closed)
What does this MR do?
save working group Function when adding a new group
plus set the 'apply_type' to 0 (nobody can apply, closed group)
plus permit admins of parent groups acess to sub groups settings
How confident are you it won't break things if deployed?
100%
Links to related issues
How to test
- Checkout branch locally
- Login as userorga
- open system administration -> manage regions
- create a new region/working group with GOALS function and save it
- reload page and check, if GOALS is still set
- goto group -> manage group: see if application is set to closed group
Screenshots (if applicable)
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
set the "API change" label if changes in the API are not backward compatible -
added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label) -
added an entry to CHANGELOG.md
-
added a short text in the release notes to /release-notes/YYYY-MM.md -
Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/region?bid=2296&sub=forum. Please change the MRs label to "state:Beta testing". - Consider writing a detailed description in German.
- Describe in a few sentences, what should be tested from a user perspective.
- Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
- Be aware, that also non technical people should understand.
Edited by Martin Goldenbaum
Merge request reports
Activity
Please register or sign in to reply