Fix the logging of profile settings
Closes #2063 (closed)
What does this MR do?
Changes in the profile settings were not logged in fs_foodsaver_change_history because
- logging was only enabled if users changed their own data (I'm guessing this was by mistake?)
- the fields in the DTO have different names than the database columns, which is why they couldn't be compared
- data was written to the database before comparing old and new data. At that point the both were actually equal.
How confident are you it won't break things if deployed?
I'm sure that the logging works again. Not sure though, if this might have any unwanted side effects.
Links to related issues
How to test
- Checkout branch locally
- Login as orga
- Go to any user's profile settings
- Change something and submit
- Check if there are entries in the fs_foodsaver_change_history table
Some changes should be visible on the profile page, like the name of the user who last changed the home region.
Screenshots (if applicable)
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
set the "API change" label if changes in the API are not backward compatible -
added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label) -
added an entry to CHANGELOG.md -
added a short text in the release notes to /release-notes/YYYY-MM.md -
Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/region?bid=734&sub=forum. Please change the MRs label to "state:Beta testing". - Consider writing a detailed description in German.
- Describe in a few sentences, what should be tested from a user perspective.
- Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
- Be aware, that also non technical people should understand.
Closes #2063 (closed)