Skip to content

Allow support group admins to change another user's login email

Alex requested to merge orga-change-internal-email into master

Closes #2031 (closed)

What does this MR do?

Allows to change someone else's login email address. This is only allowed for users who are orga and admins of the support group. The address isn't changed immediately, but a confirmation email is sent to the new address. I generalised the backend endpoint that is used for changing your own address for this. The frontend form is also the same, except that you don't have to enter the password. The request will be logged in the fs_foodsaver_change_history table.

How confident are you it won't break things if deployed?

Quite sure, because this can only affect the one other case of users changing their own address.

Links to related issues

How to test

  1. Checkout branch locally
  2. Login as orga
  3. Go to any user's profile, click "settings" in the menu
  4. In the "change email" tab, enter a new email address and submit
  5. Check on http://localhost:18084/ that two emails were sent to the old and the new address

Screenshots (if applicable)

screenshot

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • set the "API change" label if changes in the API are not backward compatible
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text in the release notes to /release-notes/YYYY-MM.md
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/region?bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.
Edited by Anton Ballmaier

Merge request reports