Skip to content

Clean up extraction session user units interface

KoeMai requested to merge 1980_cleanup_extraction_session_user_units_interface into master

Closes #1980 (closed)

What does this MR do?

The MR removes the implementation of CurrentUserUnitsInterface from Session-class. It is not required and CurrentUserUnitsSessionTransaction implementation is stable.

Some unit tests have used the CurrentUserUnitsInterface by Session. Replaced it by an Interface mock.

How confident are you it won't break things if deployed?

Should not

Links to related issues

How to test

Screenshots (if applicable)

Checklist

  • No tests required
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • set the "API change" label if changes in the API are not backward compatible
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text in the release notes to /release-notes/YYYY-MM.md
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/region?bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Merge request reports