Skip to content

Fix login url on public profile page

Alex requested to merge 1901-fix-login-ref into master

Closes #1901 (closed)

What does this MR do?

The url of the login button was using &ref= instead of ?ref=. The forwarding after login is not implemented yet, but at least the login button works again.

How confident are you it won't break things if deployed?

should work

Links to related issues

How to test

  1. Checkout branch locally
  2. Without login, open a public profile page http://localhost:18080/user/{fsid}/profile/public
  3. Click the login button

Screenshots (if applicable)

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • set the "API change" label if changes in the API are not backward compatible
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text in the release notes to /release-notes/YYYY-MM.md
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/region?bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Closes #1901 (closed)

Edited by Alex

Merge request reports

Loading