removing possibility to add user to a district

Closes issues0#405

What does this MR do?

removes the possibility to add a user to ones own district

How confident are you it won't break things if deployed?

function and call to function have been removed. should work.

Checklist

• added a test, or explain why one is not needed/possible...
• no unrelated changes
• asked someone for a code review
• joined #foodsharing-beta channel at https://slackin.yunity.org
• added an entry to CHANGELOG.md (description, merge request link, username(s))

A changelog entry is particularly useful here, as if people wanted the functionality back (or simliar) it would be easy to find their way back to the MR.

Codestyle test failure, you can run ./scripts/fix-codestyle to fix it :)

added 1 commit

• 6c576c27 - add changelog

Compare with previous version

sorry forgot the changelog - yes is vital here. changelog should be updated.

where can i see what codestyle the problem is ?

added 1 commit

• f429b31b - codestyle fix

Compare with previous version

If you look at the CI log (https://gitlab.com/foodsharing-dev/foodsharing/-/jobs/55712609), it has this line:

diff --git a/src/Modules/Foodsaver/FoodsaverView.php b/src/Modules/Foodsaver/FoodsaverView.php
index bb523ced..c59215f9 100755
--- a/src/Modules/Foodsaver/FoodsaverView.php
+++ b/src/Modules/Foodsaver/FoodsaverView.php
@@ -7,7 +7,6 @@ use Foodsharing\Modules\Core\View;
 
 class FoodsaverView extends View
 {
-
 	public function foodsaverForm($foodsaver = false)
 	{
 		if ($foodsaver === false) {
Code style check failed. See problems in the diff above.

So, just an extra whitespace line...

ok removed the empty line

@NerdyProjects pointed out two other things to remove at the same time (as otherwise we only remove the box on the website, not the actual functionality):

1. remove the public function addfoodsaver() method in FoodsaverXhr (called via ajax after you press the button)
2. remove the 'addFoodsaver' function in Foodsaver.js (called in the frontend when you press the button, from the view, which is already removed)

if someone else want's to continue - i won't be getting back to it till the evening probably.

added 1 commit

• 93c5cfca - Removed public ajax function for adding foodsavers.

Compare with previous version

added 1 commit

• 99a6c559 - Update CHANGELOG.md

Compare with previous version

marked the checklist item no unrelated changes as completed

marked the checklist item added an entry to CHANGELOG.md (description, merge request link, username(s)) as completed

changed the description

assigned to @nicksellen

marked the checklist item asked someone for a code review as completed

@k.miklobusec done @nicksellen review if you please. I have no possibility for running any test here. Has to be looked at on localhost. Should be fine though.

added 1 commit

• 55ececd4 - Remove js and model addFoodsaver code

Compare with previous version

I removed the js code, and the model code which I forgot to mention too (which was used nowhere else). Seems ok locally, if tests pass then we are good to merge to master and see how it is on beta :)

@nicksellen are you shure they are not used by the "Master-Bezirk" button on https://foodsharing.de/?page=region ?

Whenn setting a master district to some other district, there is a possibility to add all foodsavers from the district to the master district. We should not break this.

I did code search, text search, and matthias-brain search :)

@nicksellen I guess that should be enough effort spend then. Well, let's see what it looks like. Thanks for your input.

approved this merge request

merged

changed milestone to %Hackweek February 2018