Skip to content

Refactor configuration constants

Matthias Larisch requested to merge get-rid-of-base-url into master

What does this MR do?

There were multiple constants defining same/similar things (BASE_URL, URL_INTERN, LINK_URL) as well as some confusion about the email hostname part (DEFAULT_HOST which sometimes meant DEFAULT_EMAIL_HOST and sometimes BASE_URL).

This MR cleans that up.

It also adds SUPPORT_EMAIL instead of fixed it@lebensmittelretten.de. I did not write tests...

How confident are you it won't break things if deployed?

I was concious while doing the replacements :-)

Links to related issues

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))

Merge request reports