Skip to content

Fix XSS Vulnerabilities in Baskets, Mails and Blog

Stefan C requested to merge fix-xss-baskets-mail-blog into master

What does this MR do?

This MR fix some XSS vulnerabilities

How confident are you it won't break things if deployed?

It might break some HTML formatting, where untrusted content is used

How to test

Baskets, Mails and Blog entries should not be trivial vulnerable anymore.

TODO:

  • Create Hotfix after merging

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text in the release notes to /release-notes/YYYY-MM.md
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/region?bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Merge request reports