Skip to content

Buntel followup configure columns in storelist

Buntel requested to merge buntel-followup-configure-columns-in-storelist into master

What does this MR do?

  • fixes unsaved changes prompt when there are no changes.
  • offer an alternate preset of field order for mobile devices (actually when the table content is overflowing)
  • fix displaying stores from ancestor regions
  • improve requests
  • fix state (each url has it's own state now, each component has it's own settings)

How confident are you it won't break things if deployed?

😄

Links to related issues

!2733 (merged)

How to test

Preset

  1. delete local cache
  2. go to "Meine Betriebe" oder "Bezirk -> Betriebe"
  3. if content is not overflowing "status" shuould be the first column
  4. shrink the window until the layout changes. Now "name" should be the first column
  5. make the window large again. "status" should be first.

Bug

  1. go to "Meine Betriebe" oder "Bezirk -> Betriebe"
  2. filter the store list
  3. refresh the page or visit another site. No prompt should be made.
  4. open list settings. change something (do not hit the save or close button). refresh the page. No you should see a prompt.
  5. test what came to your mind.

Screenshots (if applicable)

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text in the release notes to /release-notes/YYYY-MM.md
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/region?bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.
Edited by Buntel

Merge request reports