Refactor Activity Api Enpoint
Closes #____ (e.g. #230 (closed))
What does this MR do?
Revision of the Activity Rest Api endpoint
- change from annotation to attributes
- adaptation of affected interfaces
- general code style adjustments
- tests were added
- request and response schemas have been created
How confident are you it won't break things if deployed?
sure
Links to related issues
How to test
Screenshots (if applicable)
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label) -
added an entry to CHANGELOG.md -
added a short text in the release notes to /release-notes/YYYY-MM.md -
Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/region?bid=734&sub=forum. Please change the MRs label to "state:Beta testing". - Consider writing a detailed description in German.
- Describe in a few sentences, what should be tested from a user perspective.
- Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
- Be aware, that also non technical people should understand.
Edited by Alex
Merge request reports
Activity
added forDev label
assigned to @BibaltiK
added 1 commit
- ae04df86 - refactor: Change ActivityFilterUpdate from DTO to Schema Model
added 2 commits
added 18 commits
-
5487d291...e60f8d8c - 17 commits from branch
master - a543269b - Merge branch 'master' into no-ref_add-missed-test-and-refactor-activityrestcontroller
-
5487d291...e60f8d8c - 17 commits from branch
- Resolved by Michael S.
Can you please add comments to the new model classes that briefly describe what they are used for or when they are used?
- Last reply by Michael S.
added 2 commits
Please register or sign in to reply