Skip to content

(fixes region bubbles on the map) Routing: use direct ::class references, split tables between Control and Xhr

Fridtjof requested to merge fix-xhr-routing into master

this broke in the regioncontroller refactor, but nobody seems to have noticed so far

fixes #1752 (closed)

What does this MR do?

refactors Routing to make explicit references to the classes.

Because porting Control classes to symfony Controller classes does not concern Xhr classes, those should be listed separately to avoid breaking them (like I did in #1752 (closed))

It also readds 'region' and 'bezirk' for the Xhr routes, which i previously broke with the changes in !2741 (merged)

How confident are you it won't break things if deployed?

Links to related issues

How to test

Screenshots (if applicable)

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text in the release notes to /release-notes/YYYY-MM.md
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/region?bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.
Edited by Fridtjof

Merge request reports