Skip to content

Only show last activity if user is allowed to see it

Alex requested to merge 1746-fix-last-activity into master

Closes #1746 (closed)

What does this MR do?

Instead of showing "never", the last activity on a profile page is hidden if the user is not allowed to see it.

How confident are you it won't break things if deployed?

very

Links to related issues

Relates to, but does not close #1682 (closed)

How to test

  1. Checkout branch locally
  2. Login as foodsaver
  3. You should not be able to see the last activity on any profile page
  4. Log in as userorga
  5. Now you should be able to see it on every profile page

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text in the release notes to /release-notes/YYYY-MM.md
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/region?bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Closes #1746 (closed)

Edited by Alex

Merge request reports