Skip to content

Fix wrong phone number banner

Anton Ballmaier requested to merge fix-wrong-phone-nr-banner into master

What does this MR do?

Fixes the previously usually unseeable Banner informing the user about an invalid phone number.

How confident are you it won't break things if deployed?

confident

How to test

login, set the phone number to an invalid one, go to the dashboard. Due to cashing you might have to wait up to 5 min in between.

Screenshots (if applicable)

image

Checklist

  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text in the release notes to /release-notes/YYYY-MM.md
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/region?bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.
Edited by Anton Ballmaier

Merge request reports