Skip to content

Keep unconfirmed fetch dates

Jörg S. requested to merge keep-unconfirmed-fetchdates into master

Closes #1707 (closed) and #843 (closed), obsoletes !2889 (closed)

What does this MR do?

Changes behaviour from deleting unconfirmed fetch dates in the nightly maintainance job into keeping them

Why?

The current behavior (unconfirmed entries are deleted at midnight) is a data availability problem, because it violates the required documentation requirements. In virtually all cases, the unconfirmed people were indeed at the pickup, since the general policy is: “If you are not yet confirmed for an imminent pickup, the store managers probably just haven't seen it yet, in such cases please go anyway to ensure the pickup.” The proposed change would change the behavior so that the unconfirmed slots are kept at midnight and will no longer be deleted, which would be illegitimate.

How confident are you it won't break things if deployed?

quite confident

Links to related issues

#1707 (closed), https://foodsharing.de/?page=bezirk&bid=2296&sub=forum&tid=114440, https://yunity.slack.com/archives/C1T1ZM9A4/p1692486004798979 further discussion see !2889 (closed)

How to test

Somewhat trivial change, just removes the appropriate db delete query, so maybe no explicit testing needed, but if you want to test it anyhow, look at SELECT a.date, b.id, b.name FROM fs_betrieb b INNER JOIN fs_abholer a ON b.id=a.betrieb_id WHERE a.confirmed=0 AND DATE(a.date)=DATE(NOW()) ORDER BY a.date; slightly before midnight, pick up some examples and look if they are still in the fetch history after the modified maintainance job was executed after midnight.

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text in the release notes to /release-notes/YYYY-MM.md
  • beta testing requires at least reading database access, so beta testing is not to be performed in the Beta Testing Forum, but by myself after the MR is approved
Edited by Jörg S.

Merge request reports