Skip to content

Follow-ups from Beta-Testing feedback

Anton Ballmaier requested to merge beta-testing-followups-anton into master

What does this MR do?

Multiple small fixes and improvements:

  • Fix MD input errors in selection detection
  • Only conceal MD input toolbar if input is empty (fixes not hitting the send button)
  • Default MD input max height based on screen height
  • Display subscribe button as subscribed if mail notifications are active
  • Auto-focus input in Slot description editing modal

How confident are you it won't break things if deployed?

confident

Links to related issues

Markdown Input: https://foodsharing.de/?page=bezirk&bid=734&sub=forum&tid=224391 Rework forum thread page: https://foodsharing.de/?page=bezirk&bid=734&sub=forum&tid=226224 Display distance to Store: https://foodsharing.de/?page=bezirk&bid=734&sub=forum&tid=223406 Slot descriptions: https://foodsharing.de/?page=bezirk&bid=734&sub=forum&tid=216771

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.
Edited by Anton Ballmaier

Merge request reports