Skip to content

Goodbye vMap

Alex requested to merge replace-vmap into master

What does this MR do?

Replaces the last two usages of vMap with the vue leaflet map:

  • the small map on a basket's page
  • the one on the page that lists all baskets (menu "Essenskörbe > Alle Essenskörbe")

This will also fix the pipeline for !2621 (merged)

How confident are you it won't break things if deployed?

Very sure

How to test

  1. Checkout branch locally
  2. Login as foodsaver
  3. Test on both pages mentioned above if the map is shown

Screenshots (if applicable)

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text in the release notes to /release-notes/YYYY-MM.md
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.
Edited by Alex

Merge request reports