Skip to content

Improve bell menu

Anton Ballmaier requested to merge 1684-allow-to-load-more-bells into master

Closes #1684 (closed) Closes #1685 (closed) Closes #1686 (closed) Closes #1687 (closed)

What does this MR do?

Adds some functionality to the Bell Menu (see issues)

Note: Even though unread bells are always fetched first now, if you mark a bell as read, the bells will not be fetched again, so that you can still see that bell until the next reload. This is intentional! It felt strange to mark a bell as read and possibly not see it anymore because it moved below all the unread bells. Therefor I choose this behavior.

How confident are you it won't break things if deployed?

90%

How to test

  1. Checkout branch locally
  2. Login with two accounts to have an easy way to generate bells for one of the users.
  3. try out the different features

Screenshots (if applicable)

Indicator, that there might be more bells:

image

More bells can be loaded:

image

All the buttons are disabled if they are not applicable:

image

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text in German

Das Benachrichtigungs-Dropdown wurde überarbeitet:

  • Ungelesene Benachrichtigungen werden jetzt zuerst angezeigt.
  • Es können mehr als 20 Benachrichtigungen geladen werden
  • Die Liste der Benachrichtigungen kann jeder Zeit aktualisiert werden
  • Es können alle gelesenen Benachrichtigungen auf einmal gelöscht werden
Edited by Anton Ballmaier

Merge request reports