Update for our vue leaflet map
Might close #1672 (closed) and #1665 (closed)
What does this MR do?
I updated the vue components LeafletMap, LeafletLocationPicker, and LeafletLocationSearch in a way that they don't call functions of child components anymore. Instead they use props and v-model so that vue takes care of updating their values. I hope that we will run into fewer synchronisation problems with these changes.
How confident are you it won't break things if deployed?
not very sure, needs thorough testing
How to test
- Checkout branch locally
- Login as foodsaver
- Go to your profile settings pge
- Try out the map and the address search function
- Check that there are no errors in the javascript console
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label) -
added an entry to CHANGELOG.md -
added a short text that can be used in the release notes -
Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing". - Consider writing a detailed description in German.
- Describe in a few sentences, what should be tested from a user perspective.
- Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
- Be aware, that also non technical people should understand.
Release notes text in German
Edited by Christian Walgenbach