Resolve "TypeError: Failed to execute 'observe' on 'ResizeObserver': parameter 1 is not of type 'Element'."
Closes #1660 (closed)
What does this MR do?
Changes the leaflet map to use Vue's ref instead of document.getElementById
How confident are you it won't break things if deployed?
absolutely
How to test
- Checkout branch locally
- Login as foodsaver
- Go to your profile settings http://localhost:18080/?page=settings&sub=general
- Check that the map is loading
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label) -
added an entry to CHANGELOG.md
-
added a short text that can be used in the release notes -
Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing". - Consider writing a detailed description in German.
- Describe in a few sentences, what should be tested from a user perspective.
- Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
- Be aware, that also non technical people should understand.
Release notes text in German
Closes #1660 (closed)
Edited by Alex