Resolve "Error: Typed property Foodsharing\Modules\WallPost\WallPostXhr::$table must not be accessed before initi..."
Closes #1648 (closed), #1404 (closed)
What does this MR do?
Fixes two bugs in the loading of wall posts for reports:
- The wall was being loaded on the region's report page but is only intended for the report page on the profile
- The wall's name
fsreport
caused the backend to look for the database tablefs_fsreport_has_wallpost
which is actually calledfs_report_has_wallpost
. I renamed the wall toreport
.
How confident are you it won't break things if deployed?
Quite sure that the error on this wall is fixed. I am not sure, however, if the error occurs somewhere else too.
How to test
- Checkout branch locally
- Login as userorga
- Go to any region's "Meldungsansicht" in the region menu
- Check in the browser's console that there request http://localhost:18080/xhrapp?app=wallpost&m=update&table=report&id={id}&last=0 is successful without a 500 error
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label) -
added an entry to CHANGELOG.md
-
added a short text that can be used in the release notes -
Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing". - Consider writing a detailed description in German.
- Describe in a few sentences, what should be tested from a user perspective.
- Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
- Be aware, that also non technical people should understand.
Release notes text in German
Closes #1648 (closed)
Edited by Alex