Skip to content

added a transaction to get passport date - if last_pass is empty there is a fallback to last entry from verification history

Christian Walgenbach requested to merge 1617-last_pass_null into master

Closes #1617 (closed)

What does this MR do?

We have noticed that ambassadors verify the foodsaver, but do not create a passport. However, the foodsaver wants to create the passport itself, but there is no date from the passport in the database and thus a wrong date is generated on the PDF.

The last date of verification is now used if no passport was created by the ambassador.

How confident are you it won't break things if deployed?

Links to related issues

How to test

Screenshots (if applicable)

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text in German

Edited by Christian Walgenbach

Merge request reports