Skip to content

Port RegionControl to a native Symfony controller: RegionControl is dead, long live RegionController

Fridtjof requested to merge port-regioncontroller into master

Requires !2738 (merged)

What does this MR do?

It turns RegionControl into a native Symfony controller!

RegionControl turned out to be an easy target, because

  • there was no special nginx URL rewrite magic to take care of
  • it already used Response objects throughout
  • It did not have super complex sub handling, those were all neatly dispatched through the index method

How confident are you it won't break things if deployed?

seems alright! Behaviour should be the same; just the paths are different.

Links to related issues

#1767 (closed)

How to test

Check if any view/interaction on the bezirk page broke. This was relatively dull refactoring + search/replace though, so I don't expect much to turn up.

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text in German

Edited by Fridtjof

Merge request reports