Skip to content

Use strip_tags instead of preg_replace for basket phone to keep + sign

Closes #1005 (closed)

What does this MR do?

food basket: fixes mobile phone number without the first plus from country code

How confident are you it won't break things if deployed?

not sure, newbie

Links to related issues

#1005 (closed)

How to test

  1. Checkout branch locally
  2. Login as foodsaver
  3. Create a basket and check "Per Telefonanruf"
  4. Make sure that there is an number given with leading +
  5. Press "Essenskorb veröffentlichen"
  6. Logout
  7. Login as a diffrent foodsaver (best in the same region to easier find the basket, but not nessecary)
  8. Open the foodbasket and check the telefon number given (should be with leading +)

Screenshots (if applicable)

non needed

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text in German

Erhält das führende + aus der Telefonnummer bei neuem Essenskorb

Edited by Martin Goldenbaum

Merge request reports