Resolve "Service Worker (for push notifications) is broken after !2486"
Closes #1555 (closed)
What does this MR do?
Deals with the broken service worker by adding a symlink in the appropriate place. This also needs webserver config changes
How confident are you it won't break things if deployed?
should hopefully fix a broken thing :)
Links to related issues
How to test
Screenshots (if applicable)
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label) -
added an entry to CHANGELOG.md -
added a short text that can be used in the release notes -
Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing". - Consider writing a detailed description in German.
- Describe in a few sentences, what should be tested from a user perspective.
- Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
- Be aware, that also non technical people should understand.
Merge request reports
Activity
mentioned in commit 2c0f3aaf
added 2 commits
- 18de6738 - work around issue #1555 (closed)
- 2c0f3aaf - changelog for !2599 (merged)
mentioned in merge request !2486 (merged)
Unfortunately this doesn't seem to fix the issue. In dev tools I can see 2 service workers registered one at '/' global scope one at '/public'. In the settings section you can not subscribe to push notification, once you clear the site data, because
navigator.serviceWorker.readyis never ready. I think this is because the settings site is not under the scope of the service worker. If adjusting settings in the service worker webpack plugin '../public/sw.js' -> 'sw.js' then the problem above gets fixed, but changes to serviceWorker.js are not passing through.mentioned in merge request !2671 (merged)
