Use DTOs for email addresses
What does this MR do?
Replaces the use of arrays for email addresses in the mailbox module with DTOs. The gateway then takes care of converting between JSON in the database and DTOs. This makes the mailbox code a bit more readable and the next refactoring steps easier.
How confident are you it won't break things if deployed?
Quite sure. On the dev environment everything seems to work.
How to test
Log in as someone with a mailbox (e.g. userbot), go to the mailbox page, and check if you can do everything without errors: opening mailboxes, reading mails, sending mails...
Checklist
-
added a test, or explain why one is not needed/possible... should be covered by the same tests as before -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label) -
added an entry to CHANGELOG.md -
added a short text that can be used in the release notes -
Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing". - Consider writing a detailed description in German.
- Describe in a few sentences, what should be tested from a user perspective.
- Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
- Be aware, that also non technical people should understand.