Prevent unnecessary error on calendar page
What does this MR do?
When you open the calendar export page http://foodsharing.de/?page=settings&sub=calendar, it checks if you have a token. If you don't have one, the backend returns 404, which the browser logs as an error. This changes the backend to always return 200, but with token = null if you don't have one. The behavior of the frontend doesn't change.
How confident are you it won't break things if deployed?
absolutely
How to test
- Checkout branch locally
- Login as foodsaver
- Open the calendar page (if you have a token: remove it and refresh the page)
- Check that there is no error in the browser console
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label) -
added an entry to CHANGELOG.md -
added a short text that can be used in the release notes -
Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing". - Consider writing a detailed description in German.
- Describe in a few sentences, what should be tested from a user perspective.
- Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
- Be aware, that also non technical people should understand.