Skip to content

Resolve "Error: vueUse-Error: no elements were found with selector '#basket-creator'"

Alex requested to merge 1489-fix-vue-avatar-list-import into master

Closes #1488 (closed) and #1489 (closed)

What does this MR do?

On basket and foodsharepoint pages, only call vueApply for the vue avatar lists if they were included.

How confident are you it won't break things if deployed?

very

How to test

  1. Checkout branch locally
  2. Login as foodsaver
  3. go to http://localhost:18080/essenskoerbe/find
  4. check in the developer console that no error was raised

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text in German

Closes #1489 (closed)

Merge request reports