Check regionid is not defined or a number
Closes #1469 (closed) (e.g. #230 (closed))
What does this MR do?
Checks additionally if the passed "bid" contains a number and sets it to "null" if not.
In the course of this: Adaptation of properties and passing via constructor to php 8.1 feature
How confident are you it won't break things if deployed?
Sure
Links to related issues
How to test
- Open localy http://localhost:18080/?bid=XXXXX&page=foodsaver
Screenshots (if applicable)
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label) -
added an entry to CHANGELOG.md -
added a short text that can be used in the release notes -
Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing". - Consider writing a detailed description in German.
- Describe in a few sentences, what should be tested from a user perspective.
- Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
- Be aware, that also non technical people should understand.