Skip to content

Scripts for Gitpod reworked and docker-compose cleanup

MS requested to merge Feature/Gitpod_tasks_improvment into master

What does this MR do?

  • Moved all custom docker images to local dockerfile to build on the demand (affects only PHP and mdbook)

  • Cleaned up, the docker-compose to use the docker compose override feature which keeps dev/test nearly identical

  • Renamed web-container to nginx

  • Renamed chat to websocket

  • Removed mkdirs and instead uses bin/console "foodsharing:setup" to create folder structure

  • Cleaned the script folder

  • Removed #1396 (closed)

Scripts

  • renamed many scripts — which should help to understand what it does or which toolkit is affected.
  • toolkit-env/container(optional)-commandci-backend-test, db-init or containers-init
  • some scripts are still only a commandclean, fix or test
  • start/init, stop, restart are only short hands for containers-init, containers-stop, containers-restart

CI - IMAGES ARE UNTOUCHED

How confident are you it won't break things if deployed?

🤷

Links to related issues

https://www.gitpod.io/docs/configure/workspaces/tasks

How to test

Gitpod

  1. Checkout
  2. Does it boot? ./scripts/start
  3. Is it visitable and seeded?
  4. Are the tests running? ./scripts/test → does it run?

Locally

  1. Checkout
  2. Does it boot? ./scripts/start
  3. Is it visitable and seeded?
  4. Are the tests running? ./scripts/test → does it run?

Screenshots (if applicable)

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • [-] added a short text that can be used in the release notes
  • [-] Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text in German

Closes #1426 (closed)

Edited by MS

Merge request reports