Skip to content

remove-deprecated-hsnr-for-companies

Closes #1146 (closed)

When we have the release, we need an SQL-operation to clear up the data.

What does this MR do?

This merge request removes the deprecated column "hsnr" in the company table and the usages in the code.

How confident are you it won't break things if deployed?

I'm confident, because i tested it manuelly threw the website and the tests aren't red (anymore ;))

Links to related issues

How to test

  1. Checkout branch locally
  2. Login as foodsaver / BV
  3. create, edit, and view a company of your choice.
  4. everywhere where the address is, it should be visible with a house number.
  5. In the database shouldn't be a column in table "fs_betriebe" with name "hsnr" existent

Screenshots (if applicable)

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text in German

In der Datenbank wurden interne Anpassungen bezüglich des Speicherns von Hausnummern vorgenommen. Eine veralteter Restdatensatz wurde entfernt.

Closes #1146 (closed)

Edited by Jonathan Steinker

Merge request reports