Skip to content

Resolve "Have different bell type for foodsavers who changed their district"

Closes #1129 (closed)

What does this MR do?

It is now differentiated between completely new foodsavers and foodsavers who were verified before, meaning they have a verify history. There are two different messages now: new_foodsaver_needs_verification and new_foodsaver_needs_introduction.

new_foodsaver_needs_introduction replaces the new_foodsaver message. The translations, except for "de" and "en", come from deepl or google translate.

How confident are you it won't break things if deployed?

Pretty sure.

Links to related issues

#1129 (closed)

How to test

  1. Checkout branch locally
  2. Login as a foodsaver
  3. Change your home district
  4. Depending on if the foodsaver was verified before, the table fs_bell should hold an entry with either the body new_foodsaver_needs_introduction or new_foodsaver_needs_verification

Screenshots (if applicable)

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • used "state:" labels to track this MR's state until it was beta tested
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text in German

Wechselt ein Foodsaver den Stammbezirk, kann anhand der Notification nun unterschieden werden, ob er/sie eine Einführung benötigt oder "nur" verifiziert werden muss, da er/sie schon einmal verifiziert war.

Edited by Alex

Merge request reports