Skip to content

Make chat tests work again

Jano requested to merge fix-chat-tests into master

Closes #1158 (closed)

What does this MR do?

This MR downgrades the version of socket.io-client used for testing the chat server so it is compatible again with the version of socket.io (server) used in the chat server – this makes the tests pass again. The version used for testing should always be approx. the same one as used on client side.

It also attempts to add the chat tests to the CI pipeline again.

How confident are you it won't break things if deployed?

I only changed a library used in the tests, and it makes the tests work again. This won't break anything.

Links to related issues

How to test

Let's see whether there will be a new CI run for test:backend-chat

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • used "state:" labels to track this MR's state until it was beta tested
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text in German

Edited by Jano

Merge request reports