Skip to content

Fix photo deletion in nightly maintenance

Alex requested to merge fix-nightly-photo-deletion into master

Follow-up to the follow-up to !1916 (merged)

What does this MR do?

Excludes profile photos that were uploaded with the new API from being unset in the nightly maintenance script, if the file can not be found.

How confident are you it won't break things if deployed?

works

How to test

Steps a reviewer can take to verify that this MR does what it says it does e.g.

  1. Checkout branch locally
  2. Login as foodsaver
  3. Upload a new profile picture
  4. Run maintenance: ./scripts/docker-compose run --rm --no-deps app php -f run.php Maintenance daily
  5. Check if your profile photo is still set

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • use "state:" labels to track this MR's state until it was beta tested
  • added an entry to CHANGELOG.md
  • add a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo:
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...). how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text

(A short text that will appear in the release notes and describes the change for non-technical people. Not always necessary, e.g. not for refactoring.)

Merge request reports