Skip to content

Stat fix

OnceUponAFoodsharingTime requested to merge stat_fix into master

What does this MR do?

Fixes the nightly statistic run for stores.

It seems like the one use of storeId for multiple places in a select doesn't work - so i renamed them to
storeIdA,storeIdB,storeIdC

How confident are you it won't break things if deployed?

should work

Links to related issues

How to test

Steps a reviewer can take to verify that this MR does what it says it does e.g. It just looks like many steps because it's detailed.

  1. Checkout branch locally
  2. run ./script/seed
  3. Go to http://localhost:18081
  4. Go to table fs_betrieb_team
  5. Check that the fields stat_fetchcount, stat_first_fetch, stat_last_fetch have no values (0,null)
  6. Checkout master branch.
  7. Run ./scripts/docker-compose run --rm --no-deps app php -f run.php Stats betriebe
  8. Check steps 3-5
  9. Checkout stat_fix branch.
  10. Run ./scripts/docker-compose run --rm --no-deps app php -f run.php Stats betriebe
  11. check fs_betrieb_team and columns stat_fetchcount, stat_first_fetch, stat_last_fetch should have values now.
  12. SELECT * FROM fs_betrieb_team order by foodsaver_id, stat_fetchcount

Screenshots (if applicable)

Any relevant screenshots if this is a design / frontend change

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • use "state:" labels to track this MR's state until it was beta tested
  • added an entry to CHANGELOG.md
  • add a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo:
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...). how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text

(A short text that will appear in the release notes and describes the change for non-technical people. Not always necessary, e.g. not for refactoring.)

Edited by OnceUponAFoodsharingTime

Merge request reports