Fix the duplicate button on the workgroup application dialog
Closes #1049 (closed)
What does this MR do?
An old commit trying to simplify a bit of v_form accidentally broke an option used by WorkGroupView's applyForm to hide the default submit button (which does not work correctly in this one case). (for anyone wondering, a working button is added in WorkGroupXhr::apply, which is the only XHR that uses the applyForm anyway)
How confident are you it won't break things if deployed?
very confident
Links to related issues
How to test
- checkout branch
- login as a foodsaver
- go to the workgroup (AG) list for a region
- apply for any workgroup with the button "Für diese Arbeitsgruppe bewerben"/"Apply for this group"
- see that there is only one submit button and that it works correctly (no error pages)
Screenshots (if applicable)
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
use "state:" labels to track this MR's state until it was beta tested -
added an entry to CHANGELOG.md -
add a short text that can be used in the release notes -
Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo: - Consider writing a detailed description in German.
- Describe in a few sentences, what should be tested from a user perspective.
- Also mention different settings (e.g. different browsers, roles, ...). how this change can be tested.
- Be aware, that also non technical people should understand.
Release notes text
Edited by Fridtjof