Skip to content

Restrict search in store edit dialog to the store's region

Alex requested to merge store-db-quick-fix into master

Part of #1012 (closed)

What does this MR do?

The store page creates a lot of load on the server because the "team edit" dialog is always loaded and contains the user data (for the tagedit) for all users from all regions in which the logged in user is a member. This changes that to only include the store's region.

It's a temporarily solution to bring down the server load until the edit dialog can be loaded dynamically or the tagedit can use a search endpoint.

How confident are you it won't break things if deployed?

Should work

How to test

Steps a reviewer can take to verify that this MR does what it says it does e.g.

  1. Checkout branch locally
  2. Login as store manager (userbot)
  3. Go to a store and edit the team
  4. You should still be able to add users to the team

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • use "state:" labels to track this MR's state until it was beta tested
  • added an entry to CHANGELOG.md
  • add a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo:
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...). how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text

Die Auto-Vervollständigung im "Team Bearbeiten"-Dialog ist vorerst auf Menschen aus dem Bezirk des Betriebs beschränkt, um den Server zu entlasten.

Edited by Alex

Merge request reports